Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable health check that includes crunchydb cluster check #3445

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Mar 1, 2024

  • Adds role/rolebinding for allowing the status checker service account to request crunchydb postgres resources
    • these were just recreated with oc -n <namespace> apply -f get-postgres-clusters-role.yaml and oc -n <namespace> apply -f status-checker-role-binding.yaml
  • Re-enables health check in API, with some renaming
  • Re-enables tests with new crunchydb resource fixture
  • closes CrunchyDB: API Health Check #3390

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad self-assigned this Mar 1, 2024
@conbrad conbrad requested review from dgboss and brettedw March 1, 2024 00:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (01ddb92) to head (9d57406).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
+ Coverage   81.03%   81.33%   +0.30%     
==========================================
  Files         281      281              
  Lines       10050    10053       +3     
  Branches      495      495              
==========================================
+ Hits         8144     8177      +33     
+ Misses       1771     1741      -30     
  Partials      135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@conbrad conbrad temporarily deployed to production March 4, 2024 22:47 Inactive
@conbrad conbrad temporarily deployed to production March 4, 2024 23:49 Inactive
@conbrad conbrad merged commit 38b29d3 into main Mar 5, 2024
28 checks passed
@conbrad conbrad deleted the task/crunchydb-health-check branch March 5, 2024 00:02
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CrunchyDB: API Health Check
3 participants