Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass curing tab #3423

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Grass curing tab #3423

merged 12 commits into from
Feb 27, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Feb 21, 2024

Adds the Grass Curing tab which displays the 'forecast' percent grass curing value and the value extracted from the Canadian Wildland Fire Information oSystem (CWFIS).

Fixes a minor where grass curing values would populate backwards in time when manually entering a new value.

No double-click support.
No Show/Hide columns support.

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ca1e215) 81.01% compared to head (ecb44f2) 81.07%.

❗ Current head ecb44f2 differs from pull request most recent head 0198f3e. Consider uploading reports for the commit 0198f3e to get more accurate results

Files Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 44.44% 4 Missing and 1 partial ⚠️
api/app/routers/morecast_v2.py 55.55% 4 Missing ⚠️
...features/moreCast2/components/ForecastDataGrid.tsx 40.00% 3 Missing ⚠️
.../features/moreCast2/components/MoreCast2Column.tsx 86.66% 1 Missing and 1 partial ⚠️
api/app/jobs/grass_curing.py 0.00% 1 Missing ⚠️
.../features/moreCast2/components/DataGridColumns.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
+ Coverage   81.01%   81.07%   +0.05%     
==========================================
  Files         281      281              
  Lines        9957     9999      +42     
  Branches      480      483       +3     
==========================================
+ Hits         8067     8107      +40     
- Misses       1763     1765       +2     
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested a review from conbrad February 21, 2024 19:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 77.02703% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 81.10%. Comparing base (1e1691a) to head (faf5095).

Files Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 44.44% 4 Missing and 1 partial ⚠️
api/app/routers/morecast_v2.py 55.55% 4 Missing ⚠️
...features/moreCast2/components/ForecastDataGrid.tsx 40.00% 3 Missing ⚠️
.../features/moreCast2/components/MoreCast2Column.tsx 86.66% 1 Missing and 1 partial ⚠️
api/app/jobs/grass_curing.py 0.00% 1 Missing ⚠️
.../features/moreCast2/components/DataGridColumns.tsx 83.33% 1 Missing ⚠️
web/src/features/moreCast2/util.ts 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
+ Coverage   81.02%   81.10%   +0.07%     
==========================================
  Files         281      281              
  Lines        9961    10018      +57     
  Branches      480      487       +7     
==========================================
+ Hits         8071     8125      +54     
- Misses       1763     1765       +2     
- Partials      127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested a review from brettedw February 26, 2024 21:18
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

web/src/features/moreCast2/util.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgboss dgboss temporarily deployed to production February 27, 2024 16:55 Inactive
@dgboss dgboss merged commit fc12d82 into main Feb 27, 2024
26 checks passed
@dgboss dgboss deleted the task/gc-tab/3395 branch February 27, 2024 17:48
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants