Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bias adjustment calcs for GDPS and GFS #3308

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Jan 5, 2024

GFS and GDPS weather models only contain predictions at 3 hour intervals and no prediction exists at 20:00 UTC. As a result, there is no 20:00 hour when training a linear regression model and using it to make a prediction.

As a work around I am taking the prediction at 18:00 and getting a bias adjusted value, do the same at 21:00 and finally use linear interpolation to estimate the bias adjusted value at 20:00.

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (e65eeb4) 81.97% compared to head (530534c) 81.84%.

Files Patch % Lines
api/app/jobs/common_model_fetchers.py 12.50% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3308      +/-   ##
==========================================
- Coverage   81.97%   81.84%   -0.14%     
==========================================
  Files         276      276              
  Lines        9532     9550      +18     
  Branches      450      450              
==========================================
+ Hits         7814     7816       +2     
- Misses       1599     1615      +16     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dgboss dgboss temporarily deployed to production January 8, 2024 23:40 Inactive
@dgboss dgboss merged commit 32f7a0c into main Jan 9, 2024
31 checks passed
@dgboss dgboss deleted the bug/missing-global-bias/3306 branch January 9, 2024 16:43
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants