Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoreCast Wind Direction bias bug #3280

Merged
merged 3 commits into from
Dec 11, 2023
Merged

MoreCast Wind Direction bias bug #3280

merged 3 commits into from
Dec 11, 2023

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Dec 9, 2023

Bug fix on calculating wind direction bias. Letting this run over the weekend

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22aa347) 81.97% compared to head (6127759) 81.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3280   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files         276      276           
  Lines        9532     9532           
  Branches      450      450           
=======================================
  Hits         7814     7814           
  Misses       1599     1599           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@brettedw brettedw temporarily deployed to production December 11, 2023 20:42 Inactive
@brettedw brettedw merged commit c47310a into main Dec 11, 2023
32 checks passed
@brettedw brettedw deleted the bug/wind-dir-bias branch December 11, 2023 20:55
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Fixes wind direction bias bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants