Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireBAT: Recalculate ffmc and isi using cffdrs #3084

Closed
wants to merge 34 commits into from

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Aug 25, 2023

  • Calculate ffmc and isi regardless of whether we're reading from WFWX or using manually input wind speed for consistency
  • Pull out critical hours calculations into critical_hours.py

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: deleted since we don't do overrides anymore

@@ -146,11 +125,11 @@ async def process_request(
lat=wfwx_station.lat,
long=wfwx_station.long,
bui=bui,
Copy link
Collaborator Author

@conbrad conbrad Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should just also recompute bui as well, even though it's not a dependency of the wind speed indices -- I think this is the only remaining fire index we read from WF1 here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note some larger than anticipated index drops here -- notably HFI, fire type and fire sizes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note some larger than anticipated index drops here -- notably HFI, fire type and fire sizes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note some larger than anticipated index drops here -- notably HFI, fire type and fire sizes, critical hours

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note some larger than anticipated index drops here -- notably HFI, fire type and fire sizes, critical hours

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete since we don't do any override anymore

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@conbrad
Copy link
Collaborator Author

conbrad commented Sep 18, 2023

Closing to save resources

@conbrad conbrad closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant