Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/actuals in summaries tab #3068

Merged
merged 8 commits into from
Aug 21, 2023
Merged

Story/actuals in summaries tab #3068

merged 8 commits into from
Aug 21, 2023

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Aug 16, 2023

  • Shows actuals in summaries tab
  • Coalesces forecast/actual values in same column with labels for tabs, removes actual only column
    • Note: the header title is still "Forecast" here, tried to change it but the cells are too small to fit "Forecast / Actual"
  • Fix dom nesting of buttons in web/src/components/DateRangeSelector.tsx
  • Replace deprecated components props with slots props in data grid components

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3068 (44eac62) into main (0ba707b) will increase coverage by 0.01%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
+ Coverage   84.80%   84.81%   +0.01%     
==========================================
  Files         300      300              
  Lines       10073    10084      +11     
  Branches      586      588       +2     
==========================================
+ Hits         8542     8553      +11     
  Misses       1370     1370              
  Partials      161      161              
Files Changed Coverage Δ
web/src/components/DateRangeSelector.tsx 40.00% <ø> (ø)
...features/moreCast2/components/ForecastDataGrid.tsx 71.42% <ø> (ø)
...s/moreCast2/components/ForecastSummaryDataGrid.tsx 66.66% <ø> (ø)
...res/moreCast2/components/GridComponentRenderer.tsx 88.63% <85.71%> (+2.14%) ⬆️
...features/moreCast2/components/ColumnDefBuilder.tsx 100.00% <100.00%> (ø)
web/src/features/moreCast2/util.ts 96.15% <100.00%> (+0.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@conbrad conbrad temporarily deployed to production August 21, 2023 15:48 Inactive
@conbrad conbrad merged commit bc1825e into main Aug 21, 2023
32 checks passed
@conbrad conbrad deleted the story/actuals-in-summaries-tab branch August 21, 2023 15:58
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants