Story/bias adjust wind/3055 #3058
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3058 +/- ##
==========================================
+ Coverage 84.77% 84.80% +0.02%
==========================================
Files 300 300
Lines 10052 10073 +21
Branches 587 586 -1
==========================================
+ Hits 8522 8542 +20
- Misses 1369 1370 +1
Partials 161 161
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -259,7 +259,7 @@ export class PrecipForecastField implements ColDefGenerator, ForecastColDefGener | |||
| } | |||
|
|
|||
| public generateColDefs = (headerName?: string) => { | |||
| return this.colDefBuilder.generateColDefs(headerName, false) | |||
| return this.colDefBuilder.generateColDefs(headerName, true) | |||
There was a problem hiding this comment.
We don't want to display the precip bias adjusted field yet.
| @@ -177,7 +177,7 @@ export class WindDirForecastField implements ColDefGenerator, ForecastColDefGene | |||
| } | |||
|
|
|||
| public generateColDefs = (headerName?: string) => { | |||
| return this.colDefBuilder.generateColDefs(headerName, false) | |||
| return this.colDefBuilder.generateColDefs(headerName, true) | |||
There was a problem hiding this comment.
Should we keep hiding the wind direction bias adjusted field until we get that sorted? Then we can move this PR along and only add the bias adjusted wind speed.
| @@ -95,15 +95,9 @@ export const columnGroupingModel: GridColumnGroupingModel = [ | |||
| // and visibility of our weather parameter tabs | |||
| function columnGroupingModelChildGenerator(weatherParam: string) { | |||
| // For a given weather model, there are tabs present in the datagrid for each WeatherDetermiante except | |||
| // WeatherDeterminate.NULL. Additioanlly, bias adjusted predictions only exist for temp and rh. | |||
| // WeatherDeterminate.NULL | |||
| let determinates: WeatherDeterminate[] = [] | |||
There was a problem hiding this comment.
I haven't stepped through the code, but I'm not sure this change will be valid if we're not showing the precip and wind direction bias adjusted values in the data grid?
There was a problem hiding this comment.
Yep it still works
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| # Key values on ModelRunGridSubsetPrediction. | |||
| # Wind direction (wdir_tgl_10_b) is handled slightly differently, so not included here. | |||
There was a problem hiding this comment.
Very minor, but I think this comment is no longer needed, unless wdir_tgl_10_b is something different
There was a problem hiding this comment.
Actually maybe this is why I'm not getting bias adjusted values for wind dir...
|
Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Andrea Williams <[email protected]> Co-authored-by: Andrea Williams <[email protected]>
Test Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator