Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASA uses pmtiles for fire centres and zones #3054

Merged
merged 20 commits into from
Aug 9, 2023
Merged

ASA uses pmtiles for fire centres and zones #3054

merged 20 commits into from
Aug 9, 2023

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Aug 8, 2023 •
edited by github-actions bot
Loading

@socket-security
Copy link

socket-security bot commented Aug 8, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@craco/craco 7.1.0 environment +21 1.34 MB dilanx
ol-pmtiles 0.1.1 network +2 774 kB bdon

@dgboss dgboss requested review from conbrad and brettedw August 8, 2023 19:51
conbrad
conbrad reviewed Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just a couple questions

web/package.json Outdated Show resolved Hide resolved
web/package.json Outdated Show resolved Hide resolved
conbrad
conbrad reviewed Aug 8, 2023
View reviewed changes
web/package.json Outdated Show resolved Hide resolved
conbrad
conbrad reviewed Aug 9, 2023
View reviewed changes
web/package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #3054 (ba57bad) into main (e63e778) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3054   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         300      300           
  Lines       10052    10052           
  Branches      587      587           
=======================================
  Hits         8522     8522           
  Misses       1369     1369           
  Partials      161      161

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

conbrad
conbrad approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dgboss dgboss temporarily deployed to production August 9, 2023 21:56 Inactive
@dgboss dgboss merged commit de73942 into main Aug 9, 2023
32 checks passed
@dgboss dgboss deleted the task/pmtiles-fire-centres branch August 9, 2023 22:52
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@dgboss @brettedw
ASA uses pmtiles for fire centres and zones (bcgov#3054)
60b34bd 
Co-authored-by: Brett Edwards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conbrad conbrad conbrad approved these changes

@brettedw brettedw Awaiting requested review from brettedw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgboss @conbrad @brettedw