Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pydantic model type int -> float #3037

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix pydantic model type int -> float #3037

merged 1 commit into from
Jul 27, 2023

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jul 26, 2023 •
edited by github-actions bot
Loading

@conbrad conbrad requested review from dgboss and brettedw July 26, 2023 23:28
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3037 (767de40) into main (08a0907) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         300      300           
  Lines       10052    10052           
  Branches      587      587           
=======================================
  Hits         8522     8522           
  Misses       1369     1369           
  Partials      161      161
Files Changed Coverage Δ
api/app/schemas/fba.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad temporarily deployed to production July 27, 2023 00:02 Inactive
@conbrad conbrad merged commit 92b8709 into main Jul 27, 2023
32 checks passed
@conbrad conbrad deleted the task/type-fix branch July 27, 2023 00:10
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@conbrad
Fix pydantic model type int -> float (bcgov#3037)
85a0c3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@brettedw brettedw Awaiting requested review from brettedw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conbrad @dgboss