Bug/wf1 post error #3023
Merged
Bug/wf1 post error #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conbrad
reviewed
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 85.13% 85.16% +0.02%
==========================================
Files 300 300
Lines 10046 10051 +5
Branches 586 587 +1
==========================================
+ Hits 8553 8560 +7
+ Misses 1335 1333 -2
Partials 158 158
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brettedw
commented
Jul 20, 2023
Raise exception on api route so it's seen by the frontend
- exceptions now using fastapi HTTPExceptions and status' - test updated to reflect catching new Exception
-Altered error messaging in the case that posting to WF1 is unsuccessful
|
Kudos, SonarCloud Quality Gate passed!
|
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
Shows an error when failing to submit a forecast to WF1 - Throws HTTPException upon failure to post along with message which surfaces on the front end - Adds/modifies several tests on both backend and frontend Co-authored-by: Conor Brady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator