Fix date comparison, delete old cold

bcgov · Jul 26, 2023 · bf74799 · bf74799
1 parent f84e798
commit bf74799
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/web/src/features/moreCast2/components/TabbedDataGrid.tsx b/web/src/features/moreCast2/components/TabbedDataGrid.tsx
@@ -31,19 +31,6 @@ export const SaveButton = styled(SaveForecastButton)(({ theme }) => ({
   right: theme.spacing(2)
 }))
 
-// const Root = styled('div')(({ theme }) => ({
-//   [`& .${classes.root}`]: {
-//     display: 'flex',
-//     flexGrow: 1,
-//     flexDirection: 'column'
-//   },
-
-//   [`& .${classes.saveButton}`]: {
-//     position: 'absolute',
-//     right: theme.spacing(2)
-//   }
-// }))
-
 const FORECAST_ERROR_MESSAGE = 'The forecast was not saved; an unexpected error occurred.'
 const FORECAST_SAVED_MESSAGE = 'Forecast was successfully saved and sent to Wildfire One.'
 const FORECAST_WARN_MESSAGE = 'Forecast not submitted. A forecast can only contain N/A values for the Wind Direction.'

diff --git a/web/src/features/moreCast2/slices/dataSlice.ts b/web/src/features/moreCast2/slices/dataSlice.ts
@@ -14,7 +14,7 @@ import { createDateInterval, rowIDHasher } from 'features/moreCast2/util'
 import { DateTime } from 'luxon'
 import { logError } from 'utils/error'
 import { MoreCast2Row } from 'features/moreCast2/interfaces'
-import { groupBy, isNumber, isUndefined } from 'lodash'
+import { groupBy, isEqual, isNumber, isUndefined } from 'lodash'
 import { StationGroupMember } from 'api/stationAPI'
 
 interface State {
@@ -308,7 +308,7 @@ export const fillMissingWeatherIndeterminates = (
     // We expect one actual per date in our date interval
     if (values.length < dateInterval.length) {
       for (const date of dateInterval) {
-        if (!values.some(value => value.utc_timestamp === date)) {
+        if (!values.some(value => isEqual(DateTime.fromISO(value.utc_timestamp), DateTime.fromISO(date)))) {
           const missing = createEmptyWeatherIndeterminate(stationCode, stationName, date, determinate)
           weatherIndeterminates.push(missing)
         }