Merge pull request #833 from tyu-avo/code_smell_fixes

code smell cleanup
bcgov · Dec 21, 2022 · 10acf78 · 10acf78
2 parents 6fc93f8 + 13d01e4
commit 10acf78
Show file tree

Hide file tree

Showing 24 changed files with 255 additions and 294 deletions.
diff --git a/api/app/resources/bookings/exam/exam_bcmp.py b/api/app/resources/bookings/exam/exam_bcmp.py
@@ -72,7 +72,7 @@ def post(self):
         else:
 
             logging.info("Creating Group Environment exam")
-            bcmp_response = self.bcmp_service.create_group_exam_bcmp(exam, booking, formatted_data["candidates_list_bcmp"], invigilator, formatted_data["pesticide_office"], g.jwt_oidc_token_info)
+            bcmp_response = self.bcmp_service.create_group_exam_bcmp(exam, booking, formatted_data["candidates_list_bcmp"], formatted_data["pesticide_office"], g.jwt_oidc_token_info)
 
 
         if bcmp_response:

diff --git a/api/app/utilities/bcmp_service.py b/api/app/utilities/bcmp_service.py
@@ -123,7 +123,7 @@ def create_individual_exam(self, exam, exam_fees, invigilator, pesticide_office,
         response = self.send_request(url, 'POST', bcmp_exam)
         return response
 
-    def create_group_exam_bcmp(self, exam, booking, candiate_list, invigilator, pesticide_office, oidc_token_info):
+    def create_group_exam_bcmp(self, exam, booking, candiate_list, pesticide_office, oidc_token_info):
         url = "%s/auth=%s;%s/JSON/create:BCMD-EXAM-GROUP" % (self.base_url, self.bcmp_user, self.auth_token)
         my_print("  ==> create_group_exam_bcmp    url: %s" % url)
 

diff --git a/appointment-frontend/package-lock.json b/appointment-frontend/package-lock.json
diff --git a/appointment-frontend/package.json b/appointment-frontend/package.json
@@ -45,7 +45,7 @@
     "@kazupon/vue-i18n-loader": "^0.5.0",
     "@types/cypress-image-snapshot": "^3.1.6",
     "@types/humps": "^2.0.1",
-    "@types/jest": "^26.0.24",
+    "@types/jest": "^27.0.1",
     "@types/puppeteer": "^5.4.5",
     "@vue/cli-plugin-babel": "^5.0.4",
     "@vue/cli-plugin-e2e-nightwatch": "^5.0.4",

diff --git a/appointment-frontend/vue.config.js b/appointment-frontend/vue.config.js
@@ -1,4 +1,4 @@
-var path = require('path')
+let path = require('path')
 module.exports = {
   configureWebpack: {
     devtool: 'source-map',

diff --git a/frontend/build/build-local.js b/frontend/build/build-local.js
@@ -2,15 +2,15 @@ require('./check-versions')()
 
 process.env.NODE_ENV = 'development'
 
-var ora = require('ora')
-var rm = require('rimraf')
-var path = require('path')
-var chalk = require('chalk')
-var webpack = require('webpack')
-var config = require('../config')
-var webpackConfig = require('./webpack.dev.conf')
+const ora = require('ora')
+const rm = require('rimraf')
+const path = require('path')
+const chalk = require('chalk')
+const webpack = require('webpack')
+const config = require('../config')
+const webpackConfig = require('./webpack.dev.conf')
 
-var spinner = ora('building for localhost...')
+const spinner = ora('building for localhost...')
 spinner.start()
 
 rm(path.join(config.build.assetsRoot, config.build.assetsSubDirectory), err => {

diff --git a/frontend/build/build-prod.js b/frontend/build/build-prod.js
@@ -2,15 +2,15 @@ require('./check-versions')()
 
 process.env.NODE_ENV = 'production'
 
-var ora = require('ora')
-var rm = require('rimraf')
-var path = require('path')
-var chalk = require('chalk')
-var webpack = require('webpack')
-var config = require('../config')
-var webpackConfig = require('./webpack.prod.conf')
+const ora = require('ora')
+const rm = require('rimraf')
+const path = require('path')
+const chalk = require('chalk')
+const webpack = require('webpack')
+const config = require('../config')
+const webpackConfig = require('./webpack.prod.conf')
 
-var spinner = ora('building for production...')
+const spinner = ora('building for production...')
 spinner.start()
 
 rm(path.join(config.build.assetsRoot, config.build.assetsSubDirectory), err => {