Migrate multiple vuex stores to pinia #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
esune
reviewed
Jan 20, 2025
src/store/modules/entity.ts
Outdated
Comment on lines
77
to
79
| console.log("fetching relationships"); | ||
| const res = await relationshipService.getRelatedTo(topic_id); | ||
| console.log(res); |
There was a problem hiding this comment.
Please don;t leave debug logs in the code. You may also want to name the variable something more explicit, rather than just res as it makes understanding the code easier.
| return ( | ||
| (moment(item1.date_effective).isBefore(item2.date_effective) ? -1 : 1) * | ||
| this.credentialTimeOrder | ||
| const ret = state?.type + "." + state?.value; |
There was a problem hiding this comment.
Can this variable be named more explicitly?
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is This is the first half of the migration from vuex to pinia stores #242