feat: #686 External API for FSP Tracker #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianliuwk1019
commented
Sep 4, 2024
api/src/app/modules/external/fsp-tracker/fsp-tracker.controller.ts
Outdated
Show resolved
Hide resolved
basilv
reviewed
Sep 6, 2024
basilv
approved these changes
Sep 6, 2024
|
The response has a little more detail (fom name, client name) than strictly necessary but that's fine and may be helpful for either troubleshooting or to accomodate requirement expansion by fsp-tracker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Once merged, code will be promoted and handed off to following workflow run.