Pidp 1002/1098 add user notification for reasons cards are inaccessible #611
Conversation
…ns-cards-are-inaccessible-
AdityaMantripragada
added
the
Ready For Review
AdityaMantripragada
requested review from
james-hollinger,
Paahn and
kakarlavinodkumar
| this.heading === 'Driver Fitness Practitioner Portal' | ||
| ) { | ||
| this.toastService.openInfoToast( | ||
| 'Insufficient college licensing to request enrolment.', |
There was a problem hiding this comment.
I think we can keep these error messages in constants and use them here.
| this.toastService.openInfoToast( | ||
| 'Insufficient college licensing to request enrolment.', | ||
| 'close', | ||
| { duration: 100000, panelClass: 'close-icon' }, |
There was a problem hiding this comment.
Same as previous. duration can be kept in constants.
…ns-cards-are-inaccessible-
There was a problem hiding this comment.
I am a bit confused by the scoring and the description on this ticket. I understand that the idea of this ticket was to provide more information to the user however the notification messages are not entirely correct. We need to perform certain calculations to inform the user more accurately of why they don't have access to a card. Luckily we already perform these calculations in the the backend in ProfileStatus.Model, so we could inform the frontend of the appropriate message to display.
AdityaMantripragada
added
DO NOT MERGE
…ns-cards-are-inaccessible-
…naccessible-' of https://github.com/bcgov/moh-pidp into Pidp-1002-Add-user-notification-for-reasons-cards-are-inaccessible-
…ns-cards-are-inaccessible-
AdityaMantripragada
changed the title
AdityaMantripragada
added
Ready For Review
…-1002-Add-user-notification-for-reasons-cards-are-inaccessible-
| @@ -251,6 +264,7 @@ public class PrescriptionRefillEformsSection : ProfileSection | |||
| { | |||
| internal override string SectionName => "prescriptionRefillEforms"; | |||
| public override string[] KeyWords => ["pharmacists", "rx"]; | |||
| public override string ErrorReason => "Incorrect credential type being used to request enrolment."; | |||
There was a problem hiding this comment.
As the same value is being used in multiple places can we define in constants and re-use in multiple places.
…ns-cards-are-inaccessible-
…naccessible-' of https://github.com/bcgov/moh-pidp into Pidp-1002-Add-user-notification-for-reasons-cards-are-inaccessible-
|
No description provided.