Pidp 705 imms bc enrolment card #588
Conversation
…cgov/moh-pidp into PIDP-705-ImmsBC-enrolment-Card
…-705-ImmsBC-enrolment-Card
| .HasGoodStanding) | ||
| && profile.HasBCProviderCredential => StatusCode.Complete, | ||
| { HasBCServicesCardCredential: true } => StatusCode.Incomplete, | ||
| _ => StatusCode.Locked |
There was a problem hiding this comment.
Please double check your logic here. I assume you based this off the ProvincialAttachmentSystemSection; but that section functions differently than all of our other ones. For PAS, we mark it as "complete" once the user has met all the requirements to enter PAS since there isn't actually a PAS enrolment for them to request. As well, this mentions endorsements which is not relevant to ImmsBC.
I would recommend you look at PrescriptionRefillEformsSection instead. For example, the section should be marked as complete when the user has an enrolment of the correct type.
| @@ -108,6 +110,7 @@ public class ProfileData | |||
| public bool HasBCServicesCardCredential { get; set; } | |||
| public bool LicenceDeclarationComplete { get; set; } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Very minor thing but there are extra newlines in this file and others; could you please remove them?
| [ProducesResponseType(StatusCodes.Status204NoContent)] | ||
| [ProducesResponseType(StatusCodes.Status400BadRequest)] | ||
| public async Task<IActionResult> CreateImmsBCEnrolment([FromServices] ICommandHandler<ImmsBC.Command, IDomainResult> handler, | ||
| [FromRoute] ImmsBC.Command command) |
There was a problem hiding this comment.
Very small formatting request: could you please align the square brackets on this line like the other endpoints
|
|
||
| public class ImmsBC | ||
| { | ||
| public static IdentifierType[] AllowedIdentifierTypes => [IdentifierType.PhysiciansAndSurgeons, IdentifierType.Pharmacist, IdentifierType.Nurse]; |
There was a problem hiding this comment.
Unfortunately there is a bit of domain knowledge that the JIRA ticket glossed over here; don't worry that you didn't catch it.
The ticket asked for users to have a college licence from the college of Physicians and Surgeons / Nurses / Pharmacists.
However, the college of Nurses and the College of Pharmacists actually have two Identifier Types each:
College of Nurses is both Nurse but also Midwife.
College of Pharmacists is both Pharmacist but also Pharm Tech.
It is rather difficult to find this knowledge in our code base without already knowing it; the one place we have it is in the PlrClient when we do a college licence search:
I believe this is the first time we have had an enrolment that includes these two Colleges so there also isn't any code you could have based it on.
|
|
||
| if (dataObj.AlreadyEnroled | ||
| || dataObj.Email == null | ||
| || !await this.plrClient.GetStandingAsync(dataObj.Cpn)) |
There was a problem hiding this comment.
The user not only needs to be in good standing, they need to have a good standing licence from the allowed types. You can do
|| !(await this.plrClient.GetStandingsDigestAsync(dto.Cpn))
.With(AllowedIdentifierTypes)
.HasGoodStanding)There was a problem hiding this comment.
As well, I believe that one of the requirements is that the user has a BC Provider Credential. This requirement should be checked both here and in the ProfileStatus for this section
| if (!await this.keycloakClient.AssignAccessRoles(dataObj.UserId, MohKeycloakEnrolment.ImmsBC)) | ||
| { | ||
| return DomainResult.Failed(); | ||
| } |
There was a problem hiding this comment.
We arn't actually assigning roles with this enrolment, just making an AccessRequest record. For now this part can be removed as well as the MohKeycloakEnrolment.ImmsBC
…-705-ImmsBC-enrolment-Card
…cgov/moh-pidp into PIDP-705-ImmsBC-enrolment-Card
|
No description provided.