DMM-407 Fix incorrect enumeration/display of proposal rankings #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue: https://bcdevex.atlassian.net/browse/DMM-407
This PR fixes 2 issues related to the display of proposal rankings when viewing an evaluated SWU or TWU opportunity:
Proposal rankings were being calculated against an incorrect query that returned duplicates of the same proposal. There was an unnecessary join being performed that returned a record of the same proposal for each question/response present. The fix was to remove that join.
Proposal rankings that were in the 'teens' -- between 10 and 20 -- were showing with incorrect suffixes (i.e.
11st). An exception for amounts in that range was added to the utility function, so that these rankings will show correctly (see screen grab for example).