Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feat/twu resources #453

Merged
merged 89 commits into from
Mar 11, 2024
Merged

WIP: Feat/twu resources #453

merged 89 commits into from
Mar 11, 2024

Conversation

bdolor
Copy link
Collaborator

@bdolor bdolor commented Jan 25, 2024 •
edited
Loading

adds the ability to create a TWU opportunity with multiple resources

bdolor and others added 16 commits January 9, 2024 13:54
@bdolor
feat: add new resource details tab
bce9fc7
@bdolor
chore: move resource into separate file
3db4385
@bdolor
chore: front-end compiling with new resources
f07031b
@bdolor
chore: wip with back-end compiling and front-end mvp working
5ea3a9c
@bdolor
fix: front-end serviceArea mislabelled
0e42e9f
@bdolor
chore: add order column to twuResource table
af08faf
@IanFonzie
feat: provide default empty resource
f3d0e98
@IanFonzie
feat: array length check helpers
5d67831
@IanFonzie
feat: ensure last resource cannot be removed
45ccb28
@bdolor
Merge pull request #452 from bcgov/feat/twu-resources-ui-tweaks
4b833d6 
Feat/twu resources UI tweaks
@bdolor
chore: create twuOpportunity request, validation working minimally
f8c63e3
@bdolor
docs: docBlock language improvement, tsdoc alignment
e6b164c
@bdolor
chore: create TWU Draft working
fc76096
@bdolor
chore: back-end compiling with resourceRecord change
fe79dad
@bdolor
chore: add backwards compatibility to serviceArea types, front-end co…
a7db76f 
…mpiling
@bdolor
chore: wip, back-end compilation error on update
4014ff8
@bdolor bdolor added the WIP label Jan 25, 2024
@IanFonzie
Copy link
Collaborator

Got it compiling; backend seems to be returning the appropriate information, but I'd like to review our approach on Monday.

bdolor and others added 25 commits February 21, 2024 07:10
@bdolor
feat: adjust pricing calculation to account for hourlyRate and target…
e2bfd5b 
…Allocation
@IanFonzie
chore: review resource border from review tab
a91cbbb
@bdolor
fix: bring knex connection syntax into latest version latest db migra…
f05570f 
…tion
@bdolor
style: update content to reflect multiple resources
ae99528
@bdolor
style: add mandatory skills to proposal, team members tab
ddce83b
@bdolor
fix: prevent editing of opportunity resource tab when published status
3dcb99e
@IanFonzie
fix: filter resources without a member from values
cdbcf0b
@IanFonzie
chore: remove hourly rate field state
607a088
@IanFonzie
fix: allow team component to properly validate during editing
1b886d3
@IanFonzie
fix: undo removal of updated text
4e1416b
@bdolor
fix: tighten restriction to editing resource details when draft only
6bfefb1
@IanFonzie
refactor: make error rendering work with options filtering
5653598
@IanFonzie
chore: update js doc
0bd5747
@bdolor
docs: add code level documentation
c0d06f3
@bdolor
fix: add additional constraint to account for undefined during opp cr…
00a54c8 
…eation
@IanFonzie
chore: change hourly rate placeholder
c49b2c1
@IanFonzie
refactor: use added state instead of resource to manage options
c650805
@IanFonzie
refactor: port resources for team members on opportunity update
f22b69f
@IanFonzie
refactor: allow object to options to specify formatter
bf39463
@IanFonzie
fix: add special case for devops specialist title case
a96071b
@IanFonzie
refactor: consistency for front-end formatting
25f2065
@IanFonzie
fix: don't preserve data for under review opps
c3722b3
@IanFonzie
fix: make check more explicit as it can be valid to have no members u…
ebb9f9c 
…pdate
@bdolor
style: adding TWU language to relevant email templates
189a8b5
@bdolor
test: fix integration tests to meet expectations of resource implemen…
184775c 
…tations
@bdolor bdolor marked this pull request as ready for review March 11, 2024 19:22
@bdolor bdolor requested a review from IanFonzie March 11, 2024 19:23
@bdolor bdolor added enhancement New feature or request and removed WIP labels Mar 11, 2024
@bdolor bdolor merged commit 2990b6f into development Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanFonzie IanFonzie Awaiting requested review from IanFonzie

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdolor @IanFonzie