Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated bifold packages and config settings #2259

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

al-rosenthal
Copy link
Contributor

What's Changed:

  • Bifold packages updated to get latest changes
  • Warning of "non-serializable" navigation fixed when navigating to credential details
  • Config registry updated with new settings
  • OpenIDCredentialRecordProvider added to App.tsx

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, and also missing Podfile.lock update. Need to run yarn ios:setup from the /app dir to update that file. The Bifold packages include an native module package (@hyperledger/aries-react-native-attestation) that includes a pod, so when you update the package version, the Podfile.lock has to be updated too.

app/container-imp.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have been linked when you ran the yarn ios:setup command

app/ios/Podfile.lock Outdated Show resolved Hide resolved
Signed-off-by: al-rosenthal <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

@bryce-mcmath bryce-mcmath merged commit cda945b into main Nov 7, 2024
16 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/PackageUpdate branch November 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants