Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back-merge main into develop #1648

Merged
merged 38 commits into from
May 9, 2024
Merged

back-merge main into develop #1648

merged 38 commits into from
May 9, 2024

Conversation

mhuseinov
Copy link
Collaborator

No description provided.

trslater and others added 13 commits April 29, 2024 10:09
* Remove check and unit test that blocked this
Always send emails for applications when submitting to LG
* Track page changes
* Add script hash to enable it to load inline
* Remove analytics service from ALCS, we are only doing tracking on portal
Daniel Haselhan and others added 3 commits May 6, 2024 13:28
* Prevents showing go to card when the referral has no card
* Was missing from some subtask views
Do not count planning referrals without cards for PR header
Add inquiry to assigned and subtask counts
Daniel Haselhan and others added 2 commits May 6, 2024 15:49
* This retains the type so not everything it octet-stream
* Code was already in place for applications
Retain file type when renaming file
Filter out PRs without Cards from Schedule
mhuseinov and others added 3 commits May 7, 2024 11:15
Empty strings as emails were causing it to fail.
- Return email sent status to resend endpoint
- Have resend endpoint fail if email not sent
Fix empty gov email causing emails to fail and success toast on fail
Daniel Haselhan and others added 2 commits May 8, 2024 10:53
Daniel Haselhan and others added 2 commits May 8, 2024 11:46
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhuseinov mhuseinov merged commit 3b03b82 into develop May 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants