-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back-merge main into develop #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment PR - 1030
Deployment PR - 1146
* Remove check and unit test that blocked this
Always send emails for applications when submitting to LG
Deployment PR - 1147
* Track page changes
* Add script hash to enable it to load inline * Remove analytics service from ALCS, we are only doing tracking on portal
Snowplow to Main
fix sending email on LFNG change on NOI
* Prevents showing go to card when the referral has no card
* Was missing from some subtask views
Do not count planning referrals without cards for PR header
Add inquiry to assigned and subtask counts
Do not populate visibility flag on Planning Review documents
* This retains the type so not everything it octet-stream * Code was already in place for applications
Retain file type when renaming file
Filter out PRs without Cards from Schedule
Empty strings as emails were causing it to fail.
…g-on-pr Fix for PR decision indexing
- Return email sent status to resend endpoint - Have resend endpoint fail if email not sent
Fix empty gov email causing emails to fail and success toast on fail
* Potential issues
Downgrade CLS Package
Mount CLS directly
Re-update CLS
properly retrieve properties for PR insert
dhaselhan
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.