Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open portal non-decision documents in new browser tab iframe #1495

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Open portal non-decision documents in new browser tab iframe #1495

merged 2 commits into from
Mar 12, 2024

Conversation

sandratoh
Copy link
Contributor

  • Add new utils method to open file in iframe with fileName as browser tab title
  • Apply method to all non-decision documents in frontend
  • Update backend controller and test files

@sandratoh sandratoh self-assigned this Mar 11, 2024
dhaselhan
dhaselhan approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

trslater
trslater approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sandratoh sandratoh merged commit b02d2b9 into develop Mar 12, 2024
3 checks passed
@sandratoh sandratoh deleted the feature/ALCS-1701-portal branch March 12, 2024 00:18
@sandratoh sandratoh restored the feature/ALCS-1701-portal branch March 13, 2024 17:34
@sandratoh sandratoh mentioned this pull request Mar 14, 2024
Merged
@dhaselhan dhaselhan deleted the feature/ALCS-1701-portal branch March 18, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaselhan dhaselhan dhaselhan approved these changes

@trslater trslater trslater approved these changes

Assignees

@sandratoh sandratoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandratoh @trslater @dhaselhan