GRAD2-2934: task is completed. #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRAD2-2934: task is completed.
cditcher
requested changes
Sep 24, 2024
| @@ -350,7 +351,8 @@ private void populate(OngoingUpdateFieldDTO field, GraduationStudentRecordEntity | |||
| private String getStringValue(Object value) { | |||
| if (value == null) | |||
| return null; | |||
| return (String) value; | |||
| String str = (String) value; | |||
There was a problem hiding this comment.
Need safety checking to avoid a classCastException. Maybe use if(value instanceof String){...}
There was a problem hiding this comment.
If instanceof operation is used, then null check is not required at line 352. I will update the code.
There was a problem hiding this comment.
The update is committed.
Enhancement is done after code review.
|
cditcher
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRAD2-2934: task is completed.