Added unit tests and excluding exception package from sonar.

bcgov · Aug 10, 2023 · 05bf5c1 · 05bf5c1
1 parent 22583fc
commit 05bf5c1
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -20,7 +20,8 @@
             src/main/java/ca/bc/gov/educ/api/gradstudent/model/**,
             src/main/java/ca/bc/gov/educ/api/gradstudent/messaging/**,
             src/main/java/ca/bc/gov/educ/api/gradstudent/scheduler/**,
-            src/main/java/ca/bc/gov/educ/api/gradstudent/util/**
+            src/main/java/ca/bc/gov/educ/api/gradstudent/util/**,
+            src/main/java/ca/bc/gov/educ/api/gradstudent/exception/**
         </sonar.exclusions>
         <sonar.junit.exclusions>
             src/main/java/ca/bc/gov/educ/api/gradstudent/messaging/**,

diff --git a/api/src/test/java/ca/bc/gov/educ/api/gradstudent/service/GraduationStatusServiceTest.java b/api/src/test/java/ca/bc/gov/educ/api/gradstudent/service/GraduationStatusServiceTest.java
@@ -1,5 +1,6 @@
 package ca.bc.gov.educ.api.gradstudent.service;
 
+import ca.bc.gov.educ.api.gradstudent.exception.EntityNotFoundException;
 import ca.bc.gov.educ.api.gradstudent.messaging.NatsConnection;
 import ca.bc.gov.educ.api.gradstudent.messaging.jetstream.FetchGradStatusSubscriber;
 import ca.bc.gov.educ.api.gradstudent.messaging.jetstream.Publisher;
@@ -46,7 +47,7 @@
 
 import static ca.bc.gov.educ.api.gradstudent.service.GraduationStatusService.PAGE_SIZE;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.Assert.assertThrows;
+import static org.junit.Assert.*;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.when;
 import static org.mockito.MockitoAnnotations.openMocks;
@@ -94,6 +95,25 @@ public void tearDown() {
 
     }
 
+    @Test
+    public void testHasStudentGraduated_GivenValidProgramCompletionDate_ExpectTrue() throws EntityNotFoundException {
+        UUID studentID = UUID.randomUUID();
+        GraduationStudentRecordEntity graduationStatusEntity = new GraduationStudentRecordEntity();
+        graduationStatusEntity.setProgramCompletionDate(new java.util.Date());
+        when(graduationStatusRepository.findById(studentID)).thenReturn(Optional.of(graduationStatusEntity));
+        boolean result = graduationStatusService.hasStudentGraduated(studentID);
+        assertTrue(result);
+    }
+
+    @Test
+    public void testHasStudentGraduated_GivenNoProgramCompletionDate_ExpectFalse() throws EntityNotFoundException {
+        UUID studentID = UUID.randomUUID();
+        GraduationStudentRecordEntity graduationStatusEntity = new GraduationStudentRecordEntity();
+        when(graduationStatusRepository.findById(studentID)).thenReturn(Optional.of(graduationStatusEntity));
+        boolean result = graduationStatusService.hasStudentGraduated(studentID);
+        assertFalse(result);
+    }
+
     @Test
     public void testGetGraduationStatusForAlgorithm() {
         // ID