fix: a bunch of public class test code smells

api/src/test/java/ca/bc/gov/educ/api/edx/controller/EdxSagaControllerTest.java

@@ -37,7 +37,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
-public class EdxSagaControllerTest extends BaseSagaControllerTest {
+class EdxSagaControllerTest extends BaseSagaControllerTest {
 
   @Autowired
   private MockMvc mockMvc;

api/src/test/java/ca/bc/gov/educ/api/edx/controller/EdxStatsControllerTest.java

@@ -28,7 +28,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.test.web.servlet.MockMvc;
 
-public class EdxStatsControllerTest extends BaseSecureExchangeControllerTest {
+class EdxStatsControllerTest extends BaseSecureExchangeControllerTest {
   @Autowired
   private MockMvc mockMvc;
   @Autowired

api/src/test/java/ca/bc/gov/educ/api/edx/controller/EdxUsersControllerTest.java

@@ -33,7 +33,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
 
-public class EdxUsersControllerTest extends BaseSecureExchangeControllerTest {
+class EdxUsersControllerTest extends BaseSecureExchangeControllerTest {
 
   @Autowired
   private MockMvc mockMvc;

api/src/test/java/ca/bc/gov/educ/api/edx/controller/SecureExchangeCommentControllerTest.java

@@ -25,7 +25,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
-public class SecureExchangeCommentControllerTest extends BaseSecureExchangeControllerTest {
+class SecureExchangeCommentControllerTest extends BaseSecureExchangeControllerTest {
     private static final SecureExchangeEntityMapper mapper = SecureExchangeEntityMapper.mapper;
     @Autowired
     private MockMvc mockMvc;

api/src/test/java/ca/bc/gov/educ/api/edx/controller/SecureExchangeControllerTest.java

@@ -35,7 +35,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
-public class SecureExchangeControllerTest extends BaseSecureExchangeControllerTest {
+class SecureExchangeControllerTest extends BaseSecureExchangeControllerTest {
 
   private static final SecureExchangeEntityMapper mapper = SecureExchangeEntityMapper.mapper;
   @Autowired

api/src/test/java/ca/bc/gov/educ/api/edx/controller/SecureExchangeDocumentControllerTest.java

@@ -37,7 +37,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
 
-public class SecureExchangeDocumentControllerTest extends BaseSecureExchangeAPITest {
+class SecureExchangeDocumentControllerTest extends BaseSecureExchangeAPITest {
   @Autowired
   private MockMvc mvc;
 

api/src/test/java/ca/bc/gov/educ/api/edx/controller/SecureExchangeNoteControllerTest.java

@@ -26,7 +26,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
-public class SecureExchangeNoteControllerTest extends BaseSecureExchangeControllerTest {
+class SecureExchangeNoteControllerTest extends BaseSecureExchangeControllerTest {
 
     private static final SecureExchangeNoteMapper noteMapper = SecureExchangeNoteMapper.mapper;
     private static final SecureExchangeEntityMapper exchangeMapper = SecureExchangeEntityMapper.mapper;

api/src/test/java/ca/bc/gov/educ/api/edx/controller/SecureExchangeStudentControllerTest.java

@@ -35,7 +35,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
-public class SecureExchangeStudentControllerTest extends BaseSecureExchangeControllerTest {
+class SecureExchangeStudentControllerTest extends BaseSecureExchangeControllerTest {
 
   private static final SecureExchangeEntityMapper mapper = SecureExchangeEntityMapper.mapper;
 

api/src/test/java/ca/bc/gov/educ/api/edx/mappers/Base64MapperTest.java

@@ -8,7 +8,7 @@
 import static org.junit.Assert.assertNull;
 
 @RunWith(SpringJUnit4ClassRunner.class)
-public class Base64MapperTest {
+class Base64MapperTest {
   private final Base64Mapper mapper = new Base64Mapper();
 
   @Test

api/src/test/java/ca/bc/gov/educ/api/edx/model/SecureExchangeDocRequirementEntityJsonTests.java

@@ -21,7 +21,7 @@
 @AutoConfigureJsonTesters
 @SpringBootTest
 @ActiveProfiles("test")
-public class SecureExchangeDocRequirementEntityJsonTests {
+class SecureExchangeDocRequirementEntityJsonTests {
     @Autowired
     private JacksonTester<SecureExchangeDocRequirement> jsonTester;
 

api/src/test/java/ca/bc/gov/educ/api/edx/model/SecureExchangeDocumentJpaTests.java

@@ -28,7 +28,7 @@
 //@DataJpaTest
 //@ActiveProfiles("test")
 //@ContextConfiguration(classes = TestSecurityConfig.class, loader= AnnotationConfigContextLoader.class)
-public class SecureExchangeDocumentJpaTests {
+class SecureExchangeDocumentJpaTests {
 
 //    @Autowired
 //    private TestEntityManager entityManager;

api/src/test/java/ca/bc/gov/educ/api/edx/model/SecureExchangeDocumentJsonTests.java

@@ -23,7 +23,7 @@
 @ContextConfiguration(classes = {SecureExchangeDocumentMapperImpl.class})
 @AutoConfigureJsonTesters
 @SpringBootTest
-public class SecureExchangeDocumentJsonTests {
+class SecureExchangeDocumentJsonTests {
     @Autowired
     private JacksonTester<SecureExchangeDocument> jsonTester;
 

api/src/test/java/ca/bc/gov/educ/api/edx/model/SecureExchangeJpaTests.java

@@ -14,7 +14,7 @@
 
 //@RunWith(SpringRunner.class)
 //@DataJpaTest
-public class SecureExchangeJpaTests {
+class SecureExchangeJpaTests {
 //    @Autowired
 //    private SecureExchangeRequestRepository repository;
 

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/EdxDistrictSecureExchangeCommentOrchestratorTest.java

@@ -38,7 +38,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class EdxDistrictSecureExchangeCommentOrchestratorTest extends BaseSagaControllerTest {
+class EdxDistrictSecureExchangeCommentOrchestratorTest extends BaseSagaControllerTest {
 
   /**
    * The Repository.

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/EdxDistrictUserActivationInviteOrchestratorTest.java

@@ -36,7 +36,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class EdxDistrictUserActivationInviteOrchestratorTest extends BaseSecureExchangeAPITest {
+class EdxDistrictUserActivationInviteOrchestratorTest extends BaseSecureExchangeAPITest {
 
 
     /**

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/EdxNewSecureExchangeOrchestratorTest.java

@@ -37,7 +37,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class EdxNewSecureExchangeOrchestratorTest extends BaseSagaControllerTest {
+class EdxNewSecureExchangeOrchestratorTest extends BaseSagaControllerTest {
 
   /**
    * The Repository.

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/EdxSchoolSecureExchangeCommentOrchestratorTest.java

@@ -40,7 +40,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class EdxSchoolSecureExchangeCommentOrchestratorTest extends BaseSagaControllerTest {
+class EdxSchoolSecureExchangeCommentOrchestratorTest extends BaseSagaControllerTest {
 
   /**
    * The Repository.

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/EdxSchoolUserActivationInviteOrchestratorTest.java

@@ -37,7 +37,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class EdxSchoolUserActivationInviteOrchestratorTest extends BaseSecureExchangeAPITest {
+class EdxSchoolUserActivationInviteOrchestratorTest extends BaseSecureExchangeAPITest {
 
   /**
    * The Repository.

api/src/test/java/ca/bc/gov/educ/api/edx/orchestrator/MoveSchoolOrchestratorTest.java

@@ -39,7 +39,7 @@
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
-public class MoveSchoolOrchestratorTest extends BaseSagaControllerTest {
+class MoveSchoolOrchestratorTest extends BaseSagaControllerTest {
 
     /**
      * The Repository.

api/src/test/java/ca/bc/gov/educ/api/edx/props/ApplicationPropertiesTest.java

@@ -5,7 +5,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 
 import static org.assertj.core.api.Assertions.assertThat;
-public class ApplicationPropertiesTest extends BaseSecureExchangeAPITest {
+class ApplicationPropertiesTest extends BaseSecureExchangeAPITest {
 
   @Autowired
   ApplicationProperties applicationProperties;

api/src/test/java/ca/bc/gov/educ/api/edx/props/EmailPropertiesTest.java

@@ -5,7 +5,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 
 import static org.assertj.core.api.Assertions.assertThat;
-public class EmailPropertiesTest extends BaseSecureExchangeAPITest {
+class EmailPropertiesTest extends BaseSecureExchangeAPITest {
 
   @Autowired
   EmailProperties emailProperties;

api/src/test/java/ca/bc/gov/educ/api/edx/schedulers/EventTaskSchedulerTest.java

@@ -24,7 +24,7 @@
 import static ca.bc.gov.educ.api.edx.constants.SagaStatusEnum.IN_PROGRESS;
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class EventTaskSchedulerTest extends BaseSecureExchangeAPITest {
+class EventTaskSchedulerTest extends BaseSecureExchangeAPITest {
   @Autowired
   EventTaskScheduler eventTaskScheduler;
   @Autowired

api/src/test/java/ca/bc/gov/educ/api/edx/schedulers/SecureExchangeSchedulerTest.java

@@ -23,7 +23,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class SecureExchangeSchedulerTest extends BaseSecureExchangeAPITest {
+class SecureExchangeSchedulerTest extends BaseSecureExchangeAPITest {
   @Autowired
   private DocumentRepository repository;
   @Autowired

api/src/test/java/ca/bc/gov/educ/api/edx/service/CHESEmailServiceTest.java

@@ -13,7 +13,7 @@
 import static org.mockito.Mockito.*;
 import static org.mockito.MockitoAnnotations.openMocks;
 
-public class CHESEmailServiceTest extends BaseSecureExchangeAPITest {
+class CHESEmailServiceTest extends BaseSecureExchangeAPITest {
 
 
   @Autowired

api/src/test/java/ca/bc/gov/educ/api/edx/service/EdxUsersServiceTests.java

@@ -22,7 +22,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class EdxUsersServiceTests extends BaseSecureExchangeAPITest {
+class EdxUsersServiceTests extends BaseSecureExchangeAPITest {
 
   @Autowired
   EdxUsersService service;

api/src/test/java/ca/bc/gov/educ/api/edx/service/EmailNotificationServiceTest.java

@@ -18,7 +18,7 @@
 import static org.mockito.MockitoAnnotations.openMocks;
 
 
-public class EmailNotificationServiceTest extends BaseSecureExchangeAPITest {
+class EmailNotificationServiceTest extends BaseSecureExchangeAPITest {
 
   @Autowired
   EmailNotificationService emailNotificationService;

api/src/test/java/ca/bc/gov/educ/api/edx/service/SecureExchangeDocumentServiceTests.java

@@ -24,7 +24,7 @@
 //import javax.transaction.Transactional;
 
 
-public class SecureExchangeDocumentServiceTests extends BaseSecureExchangeAPITest {
+class SecureExchangeDocumentServiceTests extends BaseSecureExchangeAPITest {
 
   @Autowired
   DocumentService service;

api/src/test/java/ca/bc/gov/educ/api/edx/service/SecureExchangeNoteServiceGetDeleteTests.java

@@ -20,7 +20,7 @@
 import java.util.HashSet;
 import java.util.Set;
 
-public class SecureExchangeNoteServiceGetDeleteTests extends BaseSecureExchangeAPITest {
+class SecureExchangeNoteServiceGetDeleteTests extends BaseSecureExchangeAPITest {
     @Autowired
     SecureExchangeNoteService secureExchangeNoteService;
 

api/src/test/java/ca/bc/gov/educ/api/edx/service/SecureExchangeServiceTests.java

@@ -26,7 +26,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class SecureExchangeServiceTests extends BaseSecureExchangeAPITest {
+class SecureExchangeServiceTests extends BaseSecureExchangeAPITest {
 
   @Autowired
   SecureExchangeService service;

api/src/test/java/ca/bc/gov/educ/api/edx/service/SecureExchangeStudentServiceAddTests.java

@@ -22,7 +22,7 @@
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.doReturn;
 
-public class SecureExchangeStudentServiceAddTests extends BaseSecureExchangeAPITest {
+class SecureExchangeStudentServiceAddTests extends BaseSecureExchangeAPITest {
 
     private static final SecureExchangeEntityMapper mapper = SecureExchangeEntityMapper.mapper;
     @MockBean

api/src/test/java/ca/bc/gov/educ/api/edx/service/SecureExchangeStudentServiceGetDeleteTests.java

@@ -22,7 +22,7 @@
 import java.util.Set;
 import java.util.UUID;
 
-public class SecureExchangeStudentServiceGetDeleteTests extends BaseSecureExchangeAPITest {
+class SecureExchangeStudentServiceGetDeleteTests extends BaseSecureExchangeAPITest {
 
     private static final SecureExchangeEntityMapper mapper = SecureExchangeEntityMapper.mapper;
 

api/src/test/java/ca/bc/gov/educ/api/edx/utils/JsonUtilTest.java

@@ -8,7 +8,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class JsonUtilTest {
+class JsonUtilTest {
 
   @Test
   void getJsonStringFromObject() throws JsonProcessingException {

api/src/test/java/ca/bc/gov/educ/api/edx/utils/TransformUtilTest.java

@@ -26,7 +26,7 @@ class TestChildClass extends TestParentClass {
 }
 
 @RunWith(SpringRunner.class)
-public class TransformUtilTest {
+class TransformUtilTest {
   @Test
   void testIsUppercaseField_WhenFieldInParentClass_ShouldReturnTrue()  {
     assertTrue(TransformUtil.isUppercaseField(TestChildClass.class, "filedA"));

api/src/test/java/ca/bc/gov/educ/api/edx/validator/EmailValidatorTest.java

@@ -9,7 +9,7 @@
 
 import lombok.val;
 
-public class EmailValidatorTest {
+class EmailValidatorTest {
   private final EmailValidator validator = new EmailValidator(Map.of("template1", "test template"));
 
   @ParameterizedTest