Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assumed default to sample_offset #99

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add assumed default to sample_offset #99

merged 1 commit into from
Jan 20, 2025

Conversation

j616
Copy link
Contributor

@j616 j616 commented Jan 20, 2025

Details

Add assumed default to sample_offset

Pivotal Story (if relevant)

Story URL:

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner January 20, 2025 10:48
@j616 j616 merged commit 02a45cf into main Jan 20, 2025
5 checks passed
@j616 j616 deleted the jamessa-sampleOffset branch January 20, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants