adr: add flow bit rate property definitions ADR #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnbbc
force-pushed
the
philipn-bit-rate-properties
branch
from
1d958d9 to
3b58ca9
Compare
philipnbbc
force-pushed
the
philipn-bit-rate-properties
branch
3 times, most recently
from
e417d03 to
9c74c28
Compare
11 tasks
j616
reviewed
Jan 2, 2025
This change follows a discussion which decided that segment duration should be added and a maximum 1.5 variance assumed. It was decided that the maximum segment duration was not required. The need to have segment size and maximum segment size requires further input.
philipnbbc
force-pushed
the
philipn-bit-rate-properties
branch
from
9c74c28 to
de07161
Compare
Changes have been made for further review. Note that I decided to not make the |
j616
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds draft ADR for discussion. It documents possible Flow bit rate property definitions and additional related properties.
Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/188127666
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.