Add Sources to API #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdbmg
force-pushed
the
sammg-add-sources-to-api
branch
from
cec1af4 to
e4f6ebf
Compare
12 tasks
Adds a missing schema reference for the Flow schema so that it appears in rendered documentation
samdbmg
force-pushed
the
sammg-add-sources-to-api
branch
from
e4f6ebf to
5a81a5d
Compare
philipnbbc
previously approved these changes
Feb 1, 2024
|
This implementation diverges from NMOS in some ways such as the exclusion of the high level media type (e.g. audio/video/mux/data) from the Source metadata. I'd suggest that unless we have a specific reason to diverge, we should build on previous work and include that metadata. |
j616
reviewed
Feb 8, 2024
samdbmg
force-pushed
the
sammg-add-sources-to-api
branch
from
a638608 to
0800e3a
Compare
|
ADR document updated with discussion outcomes from Tuesday's session - I'll request re-review before merge |
samdbmg
dismissed
philipnbbc’s stale review
Substantial changes made following discussion
philipnbbc
approved these changes
Feb 19, 2024
Adds details of workshop discussions to Sources ADR, along with a new Option 1a for the conclusion of that discussion: that it should be accepted without the Source graph/hierarchy piece.
Removes the `contains` and `contributes_to` properties of the Sources proposal (for ADR-0002) pending further consideration, that were added by c406e99. Makes corresponding change to documentation.
samdbmg
force-pushed
the
sammg-add-sources-to-api
branch
from
cf23998 to
3128339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/186711160
Related PRs
Followed by #19
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.