-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removes some of the steps that either don't make sense for this repo, or only make sense internally.
- Loading branch information
Showing
1 changed file
with
7 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,31 @@ | ||
| # Details | ||
| _Brief description of what this PR does._ | ||
|
|
||
| # Pivotal Story | ||
| # Pivotal Story (if relevant) | ||
| Story URL: | ||
|
|
||
| # Related PRs | ||
| _Where appropriate. Indicate order to be merged._ | ||
|
|
||
| # Links to external test runs/working deployment | ||
| _Where appropriate, if separate to default CI run_ | ||
|
|
||
| # Submitter PR Checks | ||
| _(tick as appropriate)_ | ||
|
|
||
| - [ ] Added bbc/rd-apmm-cloudfit team as a reviewer | ||
| - [ ] PR completes task/fixes bug | ||
| - [ ] Tests exercise code appropriately | ||
| - [ ] New features and API breaks are flagged in commit messages using magic strings | ||
| - [ ] Repo maintainer is notified that a release is required | ||
| - [ ] Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.) | ||
| - [ ] Downstream repos have been checked for potential breaks & fixed as needed | ||
| - [ ] APIs/UIs/CLIs updated as required | ||
| - [ ] PR added to Pivotal story | ||
| - [ ] API version has been incremented if necessary | ||
| - [ ] ADR status has been updated | ||
| - [ ] Documentation updated (README, etc.) | ||
| - [ ] PR added to Pivotal story (if relevant) | ||
| - [ ] Follow-up stories added to Pivotal | ||
| - [ ] Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch) | ||
| - [ ] Any pins against pre-releases have been removed | ||
|
|
||
| # Reviewer PR Checks | ||
| _(tick as appropriate)_ | ||
|
|
||
| - [ ] PR completes task/fixes bug | ||
| - [ ] Tests exercise code appropriately | ||
| - [ ] Design makes sense, and fits with our current code base | ||
| - [ ] Code is easy to follow | ||
| - [ ] PR size is sensible | ||
| - [ ] Commit history is sensible and tidy | ||
|
|
||
| # Info on Cloudfit PRs | ||
| - The checks above are guidelines. They don't all have to be ticked, but they should all have been considered. | ||
| - For more details on how to asses PRs, see: https://github.com/bbc/rd-apmm-docs-ways-of-working/blob/master/workflow/PRChecklist.md | ||
| # Info on PRs | ||
| The checks above are guidelines. They don't all have to be ticked, but they should all have been considered. |