Move next should respect the QuickLoop bounds #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mint-dewit
commented
Nov 6, 2024
| let rawParts = playoutModel.getAllOrderedParts() | ||
| let allowWrap = false // whether we should wrap to the first part if the curIndex + delta exceeds the total number of parts | ||
|
|
||
| const quickLoopService = new QuickLoopService(_context, playoutModel) |
There was a problem hiding this comment.
I'm not sure if this is a desirable solution or if the specific method should be exposed through the PlayoutModel instead.
There was a problem hiding this comment.
I'm not sure if it should be, but as we have getSegmentsBetweenQuickLoopMarker exposed on the PlayoutModel, it would be reasonable and consistent to expose this one too.
Julusian
approved these changes
Nov 7, 2024
| @@ -76,5 +76,5 @@ export interface IOnSetAsNextContext extends IShowStyleUserContext, IEventContex | |||
| * Multiple calls of this inside one call to `onSetAsNext` will replace earlier calls. | |||
| * @returns Whether a new Part was found using the provided offset | |||
| */ | |||
| moveNextPart(partDelta: number, segmentDelta: number): Promise<boolean> | |||
| moveNextPart(partDelta: number, segmentDelta: number, ignoreQuickLoop: boolean): Promise<boolean> | |||
There was a problem hiding this comment.
the parameter is optional in other places, including the implementation, should it be optional here too?
| let rawParts = playoutModel.getAllOrderedParts() | ||
| let allowWrap = false // whether we should wrap to the first part if the curIndex + delta exceeds the total number of parts | ||
|
|
||
| const quickLoopService = new QuickLoopService(_context, playoutModel) |
There was a problem hiding this comment.
I'm not sure if it should be, but as we have getSegmentsBetweenQuickLoopMarker exposed on the PlayoutModel, it would be reasonable and consistent to expose this one too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.