feat: exclude pieces from part keepalive #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/exclude-pieces-from-part-keepalive
branch
3 times, most recently
from
0208308
to
908c2e8
Compare
Julusian
force-pushed
the
feat/exclude-pieces-from-part-keepalive
branch
from
908c2e8
to
0fb1752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended to review each commit separately. The first does some refactoring, the last has the functional changes.
Change size isn't as bad as it looks, some new tests were added covering existing behaviour using snapshots, massively inflating the diff size.
The basic approach is that when a piece wants to not operate in the keepalive, it gets put into a 'sub-group' inside the part group. Then when the partGroup has a duration, this no-keepalive group can set an end in the form
#parentGroup.end - 123.For infinites, this is done a little differently, but as they already use their own groups with an end of the same format, we can offset that number to avoid the keepalive period