Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update meteor to 2.16, and do some preparation groundwork for 3.0
observe
toobserveAsync
andobserveChanges
toobserveChangesAsync
waitForPromise
callsNotes
This also fixes some concerns I have with some of the
*Observer
classes. I have concerns about leaks if they are in the middle of executing whilestop()
is called, to mitigate this I have given each of them a#disposed
property which allows various callbacks to know they have been disposed and make sure they don't semi-restart themselves afterstop()
is called.The most visible scenario of this is
StudioObserver
, where if stop was called while itsRundownsObserver
was being reconstructed, then thatRundownsObserver
would be leaked.There was also an issue with some of the debounces, where there could be concurrent executions of them in different fibers if the execution took longer than the debounce time. A new helper has been written and used to mitigate this
PromiseDebounce
.I suspect there were also other places of potential leaks, when multiple mongo observers were setup and if one of them threw and error the ones which succeeded would be leaked. The
waitForAllObserversReady
handler has been added to handle this safely.TODO:
PromiseDebounce
, or consider if there is an existing alternative that would work