-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA-1558 - Script switch refactor #12328
Open
amoore108
wants to merge
19
commits into
latest
Choose a base branch
from
WSTEAMA-1558-script-switch-refactor
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+128
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
changed the title
Wsteama 1558 script switch refactor
WSTEAMA-1558 - Script switch refactor
Jan 22, 2025
amoore108
commented
Jan 22, 2025
amoore108
changed the title
WSTEAMA-1558 - Script switch refactor
[DNM] WSTEAMA-1558 - Script switch refactor
Jan 22, 2025
- We want to redirect people from AMP to canonical, so remove `.amp` extension
src/app/routes/utils/fetchPageData/utils/getRouteProps/index.js
Outdated
Show resolved
Hide resolved
- Could lead to a scenario whereby a user on a paginated page switches the script to a page that doesn't exist. So its best to get rid of the query params on script change.
amoore108
changed the title
[DNM] WSTEAMA-1558 - Script switch refactor
WSTEAMA-1558 - Script switch refactor
Jan 23, 2025
karinathomasbbc
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAMA-1558
Overall changes
scriptSwitchId
logic, as well as logic tied toreact-router-dom
Code changes
<ScriptLink />
component to simplify variant switchingpath-to-regexp
libraryTesting
cyr
tolat
?renderer_env=live
).amp
removed, this is expected behaviour)cyr
tolat
?renderer_env=live
)cyr
tolat
?renderer_env=live
)Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines