Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete most watched data #12175

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Delete most watched data #12175

merged 4 commits into from
Nov 14, 2024

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Nov 14, 2024

Overall changes

The Most Watched route has been deleted quite some time ago, but we forgot to cleanup the data / remove the links from the Release Info.

Code changes

  • Delete data/{service}/mostWatched folders
  • Remove links to Most Watched on local, test & live in Simorgh Release Info

Testing

  • View Simorgh Release Info file - no links to Most Watched present

@karinathomasbbc karinathomasbbc self-assigned this Nov 14, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: All links to Most Watched have also been removed from this file, as they are no longer valid

@karinathomasbbc karinathomasbbc marked this pull request as ready for review November 14, 2024 11:58
Copy link
Contributor

@amoore108 amoore108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@karinathomasbbc karinathomasbbc merged commit 60b16e9 into latest Nov 14, 2024
11 checks passed
@karinathomasbbc karinathomasbbc deleted the delete-most-watched-data branch November 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants