Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subheadline padding adjustment #12163

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Nov 12, 2024

Overall changes

  • Adds 0.5rem padding to top and bottom of subheadline, which is then subtracted off the margin top and bottom to give more visual space to the subheadlines
  • Adds 1rem scroll-margin-top to create a bit of space between the browser elements and the focused header
Before After
Screenshot 2024-11-12 at 12 24 46 Screenshot 2024-11-12 at 12 24 22

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Nov 12, 2024
Copy link

@greenc05 greenc05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks 👍

@amoore108 amoore108 merged commit 2ce2bbe into latest Nov 12, 2024
11 checks passed
@amoore108 amoore108 deleted the subheadline-padding-adjustment branch November 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants