Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus-indicator to SubHeadline component #12162

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Nov 12, 2024

Overall changes

  • Adds focus-indicator to subheadline component, which will be used mostly with the JumpTo component
  • Changes spacing above and below subheadlines from padding to margin to allow focus-indicator to display correctly
Before After
Screenshot 2024-11-12 at 09 34 59 Screenshot 2024-11-12 at 09 42 38

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Nov 12, 2024
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amoore108 amoore108 merged commit 4c6bb92 into latest Nov 12, 2024
11 checks passed
@amoore108 amoore108 deleted the subheadline-focus-indicator branch November 12, 2024 11:21
@greenc05
Copy link

This looks good though have we just thought about this in isolation and not the functionality? e.g. Have we considered the space above the heading when the user actions a link, ideally there would be a small amount of breathing space above the heading that is viewable

@amoore108
Copy link
Contributor Author

amoore108 commented Nov 12, 2024

This looks good though have we just thought about this in isolation and not the functionality? e.g. Have we considered the space above the heading when the user actions a link, ideally there would be a small amount of breathing space above the heading that is viewable

I see what you mean. Let me have a look and see if theres something that can be done about that. Thanks for the suggestion 👍

EDIT: I'll see if its possible to do with shifting content.

@greenc05
Copy link

greenc05 commented Nov 12, 2024

Screenshot 2024-11-12 at 11 42 55

If we can add .5rem padding above and below (and take away that from the margin) that would be better I think? (Like in the screen shot) Though obvs we don't want to mess up the article spacing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants