-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wsteama 1417 add related content link to jump to component #12157
Open
LilyL0u
wants to merge
38
commits into
latest
Choose a base branch
from
WSTEAMA-1417-add-related-content-link-to-jump-to-component-2
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−30
Open
Changes from 29 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
63597ee
related content but with content shift, for educational purposes only
LilyL0u 40a18d5
add related content heading to jumpToHeadings array
LilyL0u 205bb6f
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u 0f320c1
translation for related content
LilyL0u c39f71c
Merge branch 'WSTEAMA-1417-add-related-content-link-to-jump-to-compon…
LilyL0u 79238d5
translation for most read
LilyL0u 6f8e6bf
tests fixed and one adapted to also check for related content and mos…
LilyL0u a015006
test for when related content is not present
LilyL0u 16951a0
related content in storybook
LilyL0u a4d8100
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u 432c727
remove most read and some bits like log removal
LilyL0u 079522e
Merge branch 'WSTEAMA-1417-add-related-content-link-to-jump-to-compon…
LilyL0u 39f9061
some lint fixes
LilyL0u 0552f15
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u 0e622ac
decide related content to show in article page and send into component
LilyL0u 43ea66c
Merge branch 'WSTEAMA-1417-add-related-content-link-to-jump-to-compon…
LilyL0u 9fcf10f
change tests for new way
LilyL0u 732d57e
update storybook to match logic
LilyL0u cee44d0
positive test for jumpTo component on article page
LilyL0u 1bb89d4
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u fa1e02c
update snapshot
LilyL0u 6e39739
remove unused translations
LilyL0u 63d4cb4
some clean up
LilyL0u 7238908
increase bundle size for article page
LilyL0u 51a4037
lint
LilyL0u 330be29
more lint
LilyL0u f7e0770
data-testid for related content is same format as others
LilyL0u 63a7a59
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u f3386eb
article page tests for jump to component
LilyL0u 3ecb949
remove arialabelledby id, corresponding id, snapshot, and other bits
LilyL0u 0494f88
remove arialabelled by and id from related content link, and snapshot
LilyL0u dfd2f14
remove console log
LilyL0u d401bbb
add related content to jumptToHeadings with sanitised id and change t…
LilyL0u 6e04892
change duplicate variable name
LilyL0u 2ade0d3
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
LilyL0u ffb09bc
Merge branch 'latest' into WSTEAMA-1417-add-related-content-link-to-j…
amoore108 31214b8
remove snapshot test
LilyL0u 516db9e
related content heading id change
LilyL0u File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ | |
*/ | ||
|
||
export const MIN_SIZE = 635 - 5; | ||
export const MAX_SIZE = 1175 + 5; | ||
export const MAX_SIZE = 1181 + 5; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth deleting the
blocks.find
stuff and just having a separate story for the related content link?Like: