WSTEAM1-733 Display audio on the Live Page #12031
Open
+357
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
reviewed
Oct 4, 2024
|
Noticed the background colour inside of a Post, is that ok with UX? |
good question !! will check with them |
Comment on lines
169
to
171
| expect( | ||
| container.querySelector('[data-e2e="media-loader__placeholder"]'), | ||
| ).toBeInTheDocument(); |
There was a problem hiding this comment.
Maybe we need to be more explicit in this test to check the audio SVG is in the page?
There was a problem hiding this comment.
This now checks for "data-e2e="media-loader" as theres no longer a placeholder for audio - theres no audio SVG to check for anymore either, is specific enough do you think ?
There was a problem hiding this comment.
Yeah it's better, I guess it depends what your trying to test here, are you actually testing for Audio, or are you testing that if there's an audio block it just needs to render the media loader
shayneahchoon
approved these changes
Oct 9, 2024
…bc/simorgh into WSTEAM1-733-display-audio-on-live-page
amoore108
reviewed
Oct 14, 2024
amoore108
approved these changes
Oct 14, 2024
…bc/simorgh into WSTEAM1-733-display-audio-on-live-page
shayneahchoon
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-733
Overall changes
Displays audio within live page posts
Code changes
audiorendered with theMediaLoadertocomponentsToRenderwithinPostTesting
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines