Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Allows DASH manifests which specifies a metric reporting block in the following form;
to report to the endpoint.
🛠 How
Changes the Dash.js import to use
dashjs
instead ofindex_mediaplayerOnly
, additionally addssetXHRWithCredentialsForType("DVBReporting", true)
to allow cookies to be passed with any of these reporting requests by the place - this is required in order to ID the session.✅ Testing [Semi-optional]
Mock player expanded to include
setXHRWithCredentialsForType
method.Test Guidelines
Bundle size could change as a result of this PR.