Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DVB Metrics Reporting #363

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryanmccartney
Copy link

📺 What

Allows DASH manifests which specifies a metric reporting block in the following form;

<Metrics metrics="HttpList(50,MediaSegment),RepSwitchList,PlayList,TcpList,DVBErrors"> 
    <Reporting schemeIdUri="urn:dvb:dash:reporting:2014" value="1" dvb:reportingUrl="h  ttps://example.com/metrics" dvb:probability="1000"/> 
</Metrics>

to report to the endpoint.

🛠 How

Changes the Dash.js import to use dashjs instead of index_mediaplayerOnly, additionally adds setXHRWithCredentialsForType("DVBReporting", true) to allow cookies to be passed with any of these reporting requests by the place - this is required in order to ID the session.

✅ Testing [Semi-optional]

Mock player expanded to include setXHRWithCredentialsForType method.

Test Guidelines

Test engineer sign off

Bundle size could change as a result of this PR.

@ryanmccartney ryanmccartney requested a review from a team as a code owner December 9, 2024 16:02
@ryanmccartney ryanmccartney marked this pull request as draft December 9, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant