Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Location expand environment variables #1572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hovind
Copy link

@hovind hovind commented May 8, 2024

Description

Perform location expansion on testing environment.

Motivation

I want to provide paths to the scala_test via the environment. https://github.com/ucb-bar/chiseltest requires VERILATOR_ROOT to be present in the environment. I want to use the @verilator//:verilator_executable provided by https://github.com/hdl/bazel_rules_hdl.

I removed some ifs and elses whose necessity I did not quite understand, please advice if I have broken something.

Copy link

google-cla bot commented May 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hovind hovind force-pushed the experiments/environment-location-expansion branch from 04406a2 to 580b6c4 Compare November 7, 2024 10:47
@hovind hovind force-pushed the experiments/environment-location-expansion branch from 580b6c4 to 1cb0396 Compare November 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant