Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure rules behaviour/toolchain attributes via build settings #1570

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Configure rules behaviour/toolchain attributes via build settings #1570

wants to merge 4 commits into from

Commits on Apr 25, 2024

  1. Experiment: move toolchain attrs to build settings 

    Rationale: thse settings are orhogonal to scala version.
If we will intorduce multiple toolchains for different scala versions
then we would need to repeat same attrs for each scala version

Toolchains are meant for platform specific tools/flags in our case it loosely maps to scala version
Build settings/flags are meant to change behaviour of the rules like strict_deps, use_args_file etc
    @simuons
    simuons committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    31001b8 View commit details
    Browse the repository at this point in the history

  2. Intorduce flag that switches where toolchains reads config from 

    Unfortunately bazel rules doesn't know if attr was set by user or not
bazelbuild/bazel#14434
    @simuons
    simuons committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    23b3b97 View commit details
    Browse the repository at this point in the history

  3. Move jvm_flags to build settings

    @simuons
    simuons committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    558a446 View commit details
    Browse the repository at this point in the history

  4. lint

    @simuons
    simuons committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4eb9d5a View commit details
    Browse the repository at this point in the history