feat(gazelle): Include types/stubs packages #2425
Open
+70
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ewianda for the contribution. @dougthor42, would you have time to look at this? |
dougthor42
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Is there a way we can avoid committing the binary wheels here?
| typeModule := fmt.Sprintf("%s_types", strings.ToLower(distributionName)) | ||
| if dep, _, ok := cfg.FindThirdPartyDependency(typeModule); ok { | ||
| deps.Add(dep) | ||
|
|
There was a problem hiding this comment.
Nit: remove extra newline
| // Add the type and stub dependencies if they exist. | ||
| typeModule := fmt.Sprintf("%s_types", strings.ToLower(distributionName)) | ||
| if dep, _, ok := cfg.FindThirdPartyDependency(typeModule); ok { | ||
| deps.Add(dep) |
There was a problem hiding this comment.
Please add a test case for these two to gazelle/python/testdata
Comment on lines
+9
to
+11
| whl = pathlib.Path( | ||
| pathlib.Path(__file__).parent, "testdata", "pytest-7.1.1-py3-none-any.whl" | ||
| ) |
There was a problem hiding this comment.
Nit: use / to build path:
whl = pathlib.Path(__file__).parent / "testdata" / "pytest-7.1.1-py3-none-any.whl"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic that checks if a package has a corresponding
typesorstubspackage and automatically adds that to the BUILD file. This is useful for typeckers e.g pyright , mypy