Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of doc markdown #263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix rendering of doc markdown #263

wants to merge 3 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Jun 27, 2023

Some markdown renderers choke when there's no blank line before and after lists.

@Yannic
Fix rendering of doc markdown
d9ea91e 
Some markdown renderers choke when there's no blank line before and after lists.
@Yannic Yannic requested a review from bergsieker as a code owner June 27, 2023 09:54
@Yannic
Copy link
Contributor Author

Yannic commented Jun 27, 2023

248774973-5b82079f-14db-4472-a1b3-440f15d2f5b5

EdSchouten
EdSchouten reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@EdSchouten EdSchouten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also regenerate the Go source code?

@linzhp linzhp mentioned this pull request Jul 23, 2023
Merged
@Yannic
Copy link
Contributor Author

Yannic commented Sep 10, 2023

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergsieker bergsieker bergsieker approved these changes

@EdSchouten EdSchouten EdSchouten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yannic @EdSchouten @bergsieker