Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go to 1.20.7 #471

Merged
merged 1 commit into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ validate_config: 1
tasks:
ubuntu1804:
environment:
GO_HOME: "$HOME/go-1.19.5"
GO_HOME: "$HOME/go-1.20.7"
PATH: "$PATH:$GO_HOME/bin"
shell_commands:
- "echo --- Downloading and extracting Go 1.19.5 to $GO_HOME"
- "echo --- Downloading and extracting Go 1.20.7 to $GO_HOME"
- "mkdir $GO_HOME"
- "curl https://mirror.bazel.build/golang.org/dl/go1.19.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
- "curl https://mirror.bazel.build/go.dev/dl/go1.20.7.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
- "echo +++ Check go format"
- "./check-gofmt.sh `find go -name '*.go'`"
- "./check-golint.sh"
Expand All @@ -23,12 +23,12 @@ tasks:
platform: ubuntu1804
name: "go build / test"
environment:
GO_HOME: "$HOME/go-1.19.5"
GO_HOME: "$HOME/go-1.20.7"
PATH: "$PATH:$GO_HOME/bin"
shell_commands:
- "echo --- Downloading and extracting Go 1.19.5 to $GO_HOME"
- "echo --- Downloading and extracting Go 1.20.7 to $GO_HOME"
- "mkdir $GO_HOME"
- "curl https://mirror.bazel.build/golang.org/dl/go1.19.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
- "curl https://mirror.bazel.build/go.dev/dl/go1.20.7.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
- "echo +++ Running go build"
- "go build ./..."
- "echo +++ Running go test"
Expand Down
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_depe

go_rules_dependencies()

go_register_toolchains(version = "1.19.8")
go_register_toolchains(version = "1.20.7")

# Need "build_file_proto_mode" argument.
go_repository(
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/bazelbuild/remote-apis-sdks

go 1.19
go 1.20

require (
github.com/bazelbuild/remote-apis v0.0.0-20230411132548-35aee1c4a425
Expand Down
1 change: 1 addition & 0 deletions go/pkg/reader/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func TestFileReaderSeeks(t *testing.T) {
}

for _, tc := range tests {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
path, err := testutil.CreateFile(t, false, tc.blob)
Expand Down
Loading