update go toolchain to 1.20.5

bazelbuild · Jun 30, 2023 · 8e24e44 · 8e24e44
1 parent 6c9ff44
commit 8e24e44
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
@@ -3,12 +3,12 @@ validate_config: 1
 tasks:
   ubuntu1804:
     environment:
-      GO_HOME: "$HOME/go-1.19.5"
+      GO_HOME: "$HOME/go-1.20.5"
       PATH: "$PATH:$GO_HOME/bin"
     shell_commands:
-      - "echo --- Downloading and extracting Go 1.19.5 to $GO_HOME"
+      - "echo --- Downloading and extracting Go 1.20.5 to $GO_HOME"
       - "mkdir $GO_HOME"
-      - "curl https://mirror.bazel.build/golang.org/dl/go1.19.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
+      - "curl https://mirror.bazel.build/go.dev/dl/go1.20.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
       - "echo +++ Check go format"
       - "./check-gofmt.sh `find go -name '*.go'`"
       - "./check-golint.sh"
@@ -23,12 +23,12 @@ tasks:
     platform: ubuntu1804
     name: "go build / test"
     environment:
-      GO_HOME: "$HOME/go-1.19.5"
+      GO_HOME: "$HOME/go-1.20.5"
       PATH: "$PATH:$GO_HOME/bin"
     shell_commands:
-      - "echo --- Downloading and extracting Go 1.19.5 to $GO_HOME"
+      - "echo --- Downloading and extracting Go 1.20.5 to $GO_HOME"
       - "mkdir $GO_HOME"
-      - "curl https://mirror.bazel.build/golang.org/dl/go1.19.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
+      - "curl https://mirror.bazel.build/go.dev/dl/go1.20.5.linux-amd64.tar.gz | tar xvz --strip-components=1 -C $GO_HOME"
       - "echo +++ Running go build"
       - "go build ./..."
       - "echo +++ Running go test"

diff --git a/WORKSPACE b/WORKSPACE
@@ -4,10 +4,10 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 http_archive(
     name = "io_bazel_rules_go",
-    sha256 = "6b65cb7917b4d1709f9410ffe00ecf3e160edf674b78c54a894471320862184f",
+    sha256 = "51dc53293afe317d2696d4d6433a4c33feedb7748a9e352072e2ec3c0dafd2c6",
     urls = [
-        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.39.0/rules_go-v0.39.0.zip",
-        "https://github.com/bazelbuild/rules_go/releases/download/v0.39.0/rules_go-v0.39.0.zip",
+        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",
+        "https://github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",
     ],
 )
 
@@ -25,7 +25,7 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_depe
 
 go_rules_dependencies()
 
-go_register_toolchains(version = "1.19.8")
+go_register_toolchains(version = "1.20.5")
 
 # Need "build_file_proto_mode" argument.
 go_repository(

diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/bazelbuild/remote-apis-sdks
 
-go 1.19
+go 1.20
 
 require (
 	github.com/bazelbuild/remote-apis v0.0.0-20230411132548-35aee1c4a425

diff --git a/go/pkg/reader/reader_test.go b/go/pkg/reader/reader_test.go
@@ -39,6 +39,7 @@ func TestFileReaderSeeks(t *testing.T) {
 	}
 
 	for _, tc := range tests {
+		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			path, err := testutil.CreateFile(t, false, tc.blob)