When init AndroidIDEInfo, parse the manifest to get the java pacakge name if it is null from the proto. #6558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: The resource linking is broken in IDE when custom_package is not set
Description of this change
As described in the issue: If the
custom_package = "com.myPackage",
is not set when defining akt_android_library
, and if the BUILD file is under the root of your project dir, therules_kotlin
orrules_android
will pass a null value to init the IntelljiInfo. This will cause the resource link/preview not working in the IDE.This change parse the
packageName
defined in theAndroidManifest.xml
when the passed over javaPackage name is null. And use it as the resource package.After the fix the IDE resource preview worked as expected. And when clicking on the resource from Kotlin code it will link to the resource xml definition, instead of the generated Int.