feat: multi-arch build for OCI image #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clement-Jean
requested review from
fweikert,
meteorcloudy and
Wyverald
as code owners
Clement-Jean
changed the title
fweikert
approved these changes
Sep 3, 2024
|
Thank you! |
|
@fweikert Do you know when/if it will possible to upload the arm64 images on gcr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build the image on arm64 but this image was specifically made for x86_64.
I propose to make the image available for other architectures. As we are using docker buildx we can use the
TARGETARCHargument (Automatic platform ARGs in the global scope).