Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1.0] Update MODULE.bazel version to 8.1.0 #25059

Open
wants to merge 3 commits into
base: release-8.1.0
Choose a base branch
from

Conversation

iancha1992
Copy link
Member

Update the MODULE.bazel version to 8.1.0 for the release branch.

See #25049 (comment)

@iancha1992 iancha1992 added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Jan 24, 2025
@iancha1992 iancha1992 requested a review from a team as a code owner January 24, 2025 19:03
@iancha1992 iancha1992 changed the title Update MODULE.bazel version to 8.1.0 [8.1.0] Update MODULE.bazel version to 8.1.0 Jan 24, 2025
@iancha1992 iancha1992 added this to the 8.1.0 release blockers milestone Jan 24, 2025
@iancha1992 iancha1992 enabled auto-merge January 24, 2025 19:04
@iancha1992
Copy link
Member Author

cc: @bazelbuild/triage

@Wyverald
Copy link
Member

please update the lockfiles.

@Wyverald
Copy link
Member

The diff doesn't look quite right. The .bazelversion file on release-8.1.0 still says 7.4.1 (https://github.com/bazelbuild/bazel/blob/release-8.1.0/.bazelversion), so we should either generate the lockfiles using Bazel 7.4.1, or cherry-pick 3f9f26f to release-8.1.0 first.

PiperOrigin-RevId: 717441825
Change-Id: Id77eb248002e84721fc18457c81f8178fa340888
@iancha1992
Copy link
Member Author

The diff doesn't look quite right. The .bazelversion file on release-8.1.0 still says 7.4.1 (https://github.com/bazelbuild/bazel/blob/release-8.1.0/.bazelversion), so we should either generate the lockfiles using Bazel 7.4.1, or cherry-pick 3f9f26f to release-8.1.0 first.

@Wyverald
I am running into this error when I run

bazel mod deps --lockfile_mode=update
ERROR: Traceback (most recent call last):
        File "/usr/local/google/home/heec/.cache/bazel/_bazel_heec/3029c92a619cd69b9154652fa5352d1e/external/rules_apple+/apple/internal/apple_xcframework_import.bzl", line 775, column 21, in <toplevel>
                apple_common.AppleDynamicFramework,
Error: 'struct' value has no field or method 'AppleDynamicFramework'
Available attributes: Objc, XcodeProperties, XcodeVersionConfig, apple_host_system_env, apple_platform, apple_toolchain, compilation_support, dotted_version, get_apple_config, get_cpu, get_split_build_configs, get_split_prerequisites, new_objc_provider, platform, platform_type, target_apple_env
ERROR: @@bazel_tools//tools/cpp:cc_configure.bzl does not export a module extension called cc_configure_extension, yet its use is requested at https://bcr.bazel.build/modules/abseil-cpp/20240722.0/MODULE.bazel:23:29
ERROR: Error loading '@@rules_apple+//apple:apple.bzl' for module extensions, requested by https://bcr.bazel.build/modules/rules_apple/3.5.1/MODULE.bazel:27:48: at /usr/local/google/home/heec/.cache/bazel/_bazel_heec/3029c92a619cd69b9154652fa5352d1e/external/rules_apple+/apple/apple.bzl:27:5: initialization of module 'apple/internal/apple_xcframework_import.bzl' failed: at /usr/local/google/home/heec/.cache/bazel/_bazel_heec/3029c92a619cd69b9154652fa5352d1e/external/rules_apple+/apple/apple.bzl:27:5: initialization of module 'apple/internal/apple_xcframework_import.bzl' failed
<root> ([email protected])

ERROR: Results may be incomplete as 2 extensions failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants