Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java templates in rbeconfigsgen.go #999

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

hvadehra
Copy link
Member

Uses @rules_java for bazel > 7.0.0 (including pre-releases)

  • Added tests for java template resolution, but I can't seem to find any reference to that file. Is that configured somewhere in CI or only meant for manual runs?
  • I've made sure to preserve existing behavior as much as possible. The only difference is if --bazel_version is not passed, we use the latest template.
  • I'm not happy about the naming of the templates, but I plan to clean this once support for 4.0.0 is dropped in Jan 2024, and we can bring down the number of java templates to 2.

Use @rules_java for bazel > 7.0.0
@smukherj1 smukherj1 merged commit b18c44e into bazelbuild:master Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants