Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rules_helm dependencies #3001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mering
Copy link
Contributor

@mering mering commented Oct 22, 2024

rules_oci is loaded by a non dev_dependencies module extension and therefore musn't be a dev_dependency itself.

Proposed an upstream fix for future versions in abrisco/rules_helm#107.

@bazel-io
Copy link
Member

Hello @abrisco, modules you maintain (rules_helm) have been updated in this PR. Please review the changes.

@abrisco
Copy link

abrisco commented Oct 24, 2024

I think this change can be closed in favor of #3016

@mering
Copy link
Contributor Author

mering commented Oct 25, 2024

@abrisco it would be nice if there are not random broken versions on BCR. Yanking versions is also bad as this also breaks builds which might only use other functionality which works. So I would prefer to upload this additionally (especially as it doesn't even change the behavior of the code).

abrisco
abrisco previously approved these changes Oct 30, 2024
@abrisco
Copy link

abrisco commented Oct 30, 2024

Sounds good to me!

bazel-io
bazel-io previously approved these changes Oct 30, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy
Copy link
Member

Should users just switch to the latest version? #3054

@bazel-io bazel-io dismissed stale reviews from abrisco and themself October 30, 2024 16:28

Require module maintainers' approval for newly pushed changes.

@mering
Copy link
Contributor Author

mering commented Oct 30, 2024

Should users just switch to the latest version? #3054

As always, it is recommended to use the latest version but in case people want to use an older version, they should find a working version on BCR.

rules_oci is loaded by a non dev_dependencies module extension and therefore musn't be a dev_dependency itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants