-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rules_helm dependencies #3001
base: main
Are you sure you want to change the base?
Conversation
Hello @abrisco, modules you maintain (rules_helm) have been updated in this PR. Please review the changes. |
I think this change can be closed in favor of #3016 |
@abrisco it would be nice if there are not random broken versions on BCR. Yanking versions is also bad as this also breaks builds which might only use other functionality which works. So I would prefer to upload this additionally (especially as it doesn't even change the behavior of the code). |
Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Should users just switch to the latest version? #3054 |
b530121
to
5acc712
Compare
Require module maintainers' approval for newly pushed changes.
As always, it is recommended to use the latest version but in case people want to use an older version, they should find a working version on BCR. |
rules_oci is loaded by a non dev_dependencies module extension and therefore musn't be a dev_dependency itself
5acc712
to
6b5d0ee
Compare
rules_oci is loaded by a non dev_dependencies module extension and therefore musn't be a dev_dependency itself.
Proposed an upstream fix for future versions in abrisco/rules_helm#107.