-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests for latest rules_swift and rules_apple #899
Add CI tests for latest rules_swift and rules_apple #899
Conversation
773b11c
to
baf7d3c
Compare
@@ -24,9 +24,13 @@ jobs: | |||
xcode_version: [15.2] | |||
virtual_frameworks: [true, false] | |||
sandbox: [true, false] | |||
latest_rules: [true, false] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can consider adding exclude
here for the known not working combo so that we don't even bother running it until we fixed the underlying issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to run it so that any future PRs can ensure thats green if they intended to fix the issue. I just wont mark it required in github so it wont block merges, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sounds reasonable. Looks like the latest rules don't work with bazel 6.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They also dont work in bazel 7 with vfs turned off
baf7d3c
to
417206f
Compare
This adds another matrix for testing the latest rules_apple and rules_swift without having to update our
MODULE.bazel
/WORKSPACE.bazel
files.NOTE: the latest rules dont work fully yet so im expecting these jobs to fail. I'll leave the latest jobs as not required and mark the rest required until we fix support for the latest rules.